Change javadoc explanation for Mutable List #6314
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akarnokd
reviewed
Nov 19, 2018
| @@ -8746,7 +8746,7 @@ public final Completable concatMapCompletableDelayError(Function<? super T, ? ex | |||
| * {@code CharSequence}s or {@code List}s where the objects will actually have the same | |||
| * references when they are modified and {@code distinctUntilChanged} will evaluate subsequent items as same. | |||
| * To avoid such situation, it is recommended that mutable data is converted to an immutable one, | |||
| * for example using `map(CharSequence::toString)` or `map(Collections::unmodifiableList)`. | |||
| * for example using `map(CharSequence::toString)` or `map(list -> Collections.unmodifiableList(new ArrayList<>(list))`. | |||
punitda
force-pushed
the
javadocs-distinct-until-changed-method
branch
from
593ef1c to
992f119
Compare
Codecov Report
@@ Coverage Diff @@
## 2.x #6314 +/- ##
=========================================
Coverage 98.24% 98.24%
+ Complexity 6286 6281 -5
=========================================
Files 672 672
Lines 44992 44992
Branches 6223 6223
=========================================
Hits 44201 44201
- Misses 244 250 +6
+ Partials 547 541 -6
Continue to review full report at Codecov.
|
akarnokd
approved these changes
Nov 19, 2018
vanniktech
approved these changes
Nov 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per this discussion, change javadoc for
distinctUntilChanged()method for Mutable List.