Skip to content

2.x: Fix marble of Maybe.flatMap events to MaybeSource #6155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2018

Conversation

akarnokd
Copy link
Member

Fix the marble diagram of the event-mapping Maybe.flatMap operator:

image

Tracked in: #5806

@codecov
Copy link

codecov bot commented Aug 10, 2018

Codecov Report

Merging #6155 into 2.x will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##               2.x    #6155      +/-   ##
===========================================
+ Coverage     98.2%   98.22%   +0.01%     
+ Complexity    6198     6197       -1     
===========================================
  Files          667      667              
  Lines        44857    44857              
  Branches      6213     6213              
===========================================
+ Hits         44053    44059       +6     
+ Misses         259      255       -4     
+ Partials       545      543       -2
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Maybe.java 100% <ø> (ø) 171 <0> (ø) ⬇️
...tivex/internal/observers/FutureSingleObserver.java 94.33% <0%> (-3.78%) 24% <0%> (-1%)
...ternal/operators/observable/ObservablePublish.java 96.46% <0%> (-3.54%) 11% <0%> (ø)
...rnal/operators/flowable/FlowableFlatMapSingle.java 92.93% <0%> (-2.72%) 2% <0%> (ø)
...rnal/operators/observable/ObservableSwitchMap.java 93.61% <0%> (-2.66%) 3% <0%> (ø)
...activex/internal/observers/QueueDrainObserver.java 97.43% <0%> (-2.57%) 21% <0%> (-1%)
.../io/reactivex/disposables/CompositeDisposable.java 98.14% <0%> (-1.86%) 39% <0%> (-1%)
...java/io/reactivex/processors/PublishProcessor.java 98.19% <0%> (-1.81%) 42% <0%> (-1%)
...l/operators/observable/ObservableFlatMapMaybe.java 92.81% <0%> (-1.31%) 2% <0%> (ø)
...perators/mixed/ObservableSwitchMapCompletable.java 98.94% <0%> (-1.06%) 3% <0%> (ø)
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a16f63f...cee20b9. Read the comment docs.

@akarnokd akarnokd merged commit 835ab00 into ReactiveX:2.x Aug 10, 2018
@akarnokd akarnokd deleted the MaybeFlatMapEventMarble branch August 10, 2018 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants