-
Notifications
You must be signed in to change notification settings - Fork 7.6k
2.x: Add Completable.takeUntil(Completable) operator #6079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
145 changes: 145 additions & 0 deletions
145
...ain/java/io/reactivex/internal/operators/completable/CompletableTakeUntilCompletable.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,145 @@ | ||
/** | ||
* Copyright (c) 2016-present, RxJava Contributors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in | ||
* compliance with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software distributed under the License is | ||
* distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See | ||
* the License for the specific language governing permissions and limitations under the License. | ||
*/ | ||
|
||
package io.reactivex.internal.operators.completable; | ||
|
||
import java.util.concurrent.atomic.*; | ||
|
||
import io.reactivex.*; | ||
import io.reactivex.annotations.Experimental; | ||
import io.reactivex.disposables.Disposable; | ||
import io.reactivex.internal.disposables.DisposableHelper; | ||
import io.reactivex.plugins.RxJavaPlugins; | ||
|
||
/** | ||
* Terminates the sequence if either the main or the other Completable terminate. | ||
* @since 2.1.17 - experimental | ||
*/ | ||
@Experimental | ||
public final class CompletableTakeUntilCompletable extends Completable { | ||
|
||
final Completable source; | ||
|
||
final CompletableSource other; | ||
|
||
public CompletableTakeUntilCompletable(Completable source, | ||
CompletableSource other) { | ||
this.source = source; | ||
this.other = other; | ||
} | ||
|
||
@Override | ||
protected void subscribeActual(CompletableObserver s) { | ||
TakeUntilMainObserver parent = new TakeUntilMainObserver(s); | ||
s.onSubscribe(parent); | ||
|
||
other.subscribe(parent.other); | ||
source.subscribe(parent); | ||
} | ||
|
||
static final class TakeUntilMainObserver extends AtomicReference<Disposable> | ||
implements CompletableObserver, Disposable { | ||
|
||
private static final long serialVersionUID = 3533011714830024923L; | ||
|
||
final CompletableObserver downstream; | ||
|
||
final OtherObserver other; | ||
|
||
final AtomicBoolean once; | ||
|
||
TakeUntilMainObserver(CompletableObserver downstream) { | ||
this.downstream = downstream; | ||
this.other = new OtherObserver(this); | ||
this.once = new AtomicBoolean(); | ||
} | ||
|
||
@Override | ||
public void dispose() { | ||
if (once.compareAndSet(false, true)) { | ||
DisposableHelper.dispose(this); | ||
DisposableHelper.dispose(other); | ||
} | ||
} | ||
|
||
@Override | ||
public boolean isDisposed() { | ||
return once.get(); | ||
} | ||
|
||
@Override | ||
public void onSubscribe(Disposable d) { | ||
DisposableHelper.setOnce(this, d); | ||
} | ||
|
||
@Override | ||
public void onComplete() { | ||
if (once.compareAndSet(false, true)) { | ||
DisposableHelper.dispose(other); | ||
downstream.onComplete(); | ||
} | ||
} | ||
|
||
@Override | ||
public void onError(Throwable e) { | ||
if (once.compareAndSet(false, true)) { | ||
DisposableHelper.dispose(other); | ||
downstream.onError(e); | ||
} else { | ||
RxJavaPlugins.onError(e); | ||
} | ||
} | ||
|
||
void innerComplete() { | ||
if (once.compareAndSet(false, true)) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Emit error if called more than once? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No. It could legitimately lose a race against |
||
DisposableHelper.dispose(this); | ||
downstream.onComplete(); | ||
} | ||
} | ||
|
||
void innerError(Throwable e) { | ||
if (once.compareAndSet(false, true)) { | ||
DisposableHelper.dispose(this); | ||
downstream.onError(e); | ||
} else { | ||
RxJavaPlugins.onError(e); | ||
} | ||
} | ||
|
||
static final class OtherObserver extends AtomicReference<Disposable> | ||
implements CompletableObserver { | ||
|
||
private static final long serialVersionUID = 5176264485428790318L; | ||
final TakeUntilMainObserver parent; | ||
|
||
OtherObserver(TakeUntilMainObserver parent) { | ||
this.parent = parent; | ||
} | ||
|
||
@Override | ||
public void onSubscribe(Disposable d) { | ||
DisposableHelper.setOnce(this, d); | ||
} | ||
|
||
@Override | ||
public void onComplete() { | ||
parent.innerComplete(); | ||
} | ||
|
||
@Override | ||
public void onError(Throwable e) { | ||
parent.innerError(e); | ||
} | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the bird has already flown with this one but the operator
take
refers toonNext
events and we are more or less using it for all event types (take till terminates or the other thing terminates). I'm not suggesting a change perhaps a naming review for 3.x.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find it more discoverable this way and besides, the main behavior of
takeUntil
is to stop the main source and complete the downstream, regardless of there could be items from the main source or not.