Skip to content

Add marble diagram for Single.hide operator #6077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 12, 2018
Merged

Add marble diagram for Single.hide operator #6077

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ea112c
Add marble diagram for Single.hide operator
UMFsimke Jul 8, 2018
1c179ae
Use correct marble diagram URL for Single.hide method
UMFsimke Jul 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/main/java/io/reactivex/Single.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1875,6 +1875,8 @@ public final <R> R as(@NonNull SingleConverter<T, ? extends R> converter) {
/**
* Hides the identity of the current Single, including the Disposable that is sent
* to the downstream via {@code onSubscribe()}.
* <p>
* <img width="640" height="470" src="https://raw.githubusercontent.com/UMFsimke/RxJava/Images/Images/Hide.png" alt="">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a different superhero(ine) per reactive type who is relatively recognizable from the stylized head and doesn't require complicated drawings.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this one suitable?

https://github.com/UMFsimke/RxJava/blob/Images/Images/Hide2.png

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

https://raw.github.com/wiki/ReactiveX/RxJava/images/rx-operators/Single.hide.png

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated

* <dl>
* <dt><b>Scheduler:</b></dt>
* <dd>{@code hide} does not operate by default on a particular {@link Scheduler}.</dd>
Expand Down