2.x: Cleanup test local variable names #5907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanniktech
approved these changes
Mar 9, 2018
| ts.assertNoErrors(); | ||
| to.assertValue(1); | ||
| to.assertComplete(); | ||
| to.assertNoErrors(); | ||
| } | ||
|
|
||
| @Test(timeout = 5000) | ||
| public void startWithObservableError() { | ||
| Observable<Object> c = normal.completable |
There was a problem hiding this comment.
should be o and could be added to the new test class
Codecov Report
@@ Coverage Diff @@
## 2.x #5907 +/- ##
============================================
- Coverage 98.02% 97.99% -0.04%
- Complexity 5993 5994 +1
============================================
Files 655 655
Lines 43928 43928
Branches 6086 6086
============================================
- Hits 43061 43046 -15
- Misses 254 267 +13
- Partials 613 615 +2
Continue to review full report at Codecov.
|
vanniktech
approved these changes
Mar 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an unit test that scans the unit test files for common local variable misnaming due to copy-pasting between the types, such as:
TestObserver ts<->TestSubscriber toPublishSubject pp<->PublishProcessor psSee the new
CheckLocalVariablesInTestsfor other patterns described with a regexp.