Skip to content

1.x: Improve the BehaviorSubject Java doc #5048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2017
Merged

1.x: Improve the BehaviorSubject Java doc #5048

merged 1 commit into from
Feb 2, 2017

Conversation

BraisGabin
Copy link
Contributor

  • The second example didn't explain what happened with "default".
  • The first line is copied from the 2.x documentation. It's more clear.

- The second example didn't explain what happened with "default".
- The first line is copied from the 2.x documentation. It's more clear.
@codecov
Copy link

codecov bot commented Feb 2, 2017

Codecov Report

Merging #5048 into 1.x will increase coverage by 0.01%.

@@             Coverage Diff              @@
##                1.x    #5048      +/-   ##
============================================
+ Coverage     84.17%   84.19%   +0.01%     
- Complexity        0     2858    +2858     
============================================
  Files           288      288              
  Lines         17805    17805              
  Branches       2698     2420     -278     
============================================
+ Hits          14988    14991       +3     
+ Misses         1958     1957       -1     
+ Partials        859      857       -2
Impacted Files Coverage Δ Complexity Δ
src/main/java/rx/subjects/BehaviorSubject.java 97.1% <ø> (ø) 34 <ø> (+34)
...main/java/rx/internal/operators/OperatorMerge.java 86.37% <ø> (-0.47%) 7% <ø> (+7%)
...in/java/rx/internal/operators/OperatorPublish.java 78.48% <ø> (-0.43%) 8% <ø> (+8%)
...n/java/rx/subjects/SubjectSubscriptionManager.java 82.14% <ø> (+1.42%) 16% <ø> (+16%)
.../java/rx/internal/operators/BackpressureUtils.java 72.72% <ø> (+2.27%) 29% <ø> (+29%)
...n/java/rx/subscriptions/CompositeSubscription.java 76.62% <ø> (+2.59%) 24% <ø> (+24%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 748b56d...6d58972. Read the comment docs.

@akarnokd akarnokd changed the title Improve the BehaviorSubject Java doc 1.x: Improve the BehaviorSubject Java doc Feb 2, 2017
@akarnokd akarnokd added this to the 1.x Backlog & Discussions milestone Feb 2, 2017
@akarnokd akarnokd merged commit 0901ffb into ReactiveX:1.x Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants