1.x: merge/flatMap to keep scalar/inner element relative order #4209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 84.31%@@ 1.x #4209 diff @@
==========================================
Files 265 265
Lines 17281 17291 +10
Methods 0 0
Messages 0 0
Branches 2617 2619 +2
==========================================
+ Hits 14558 14579 +21
+ Misses 1881 1869 -12
- Partials 842 843 +1
|
|
Thanks @akarnokd for quick fix. I haven't reviewed yet but I'm keen to see the issue resolved in a release soon (I also was suprised |
| @@ -352,9 +352,15 @@ void tryEmit(InnerSubscriber<T> subscriber, T value) { | |||
| } | |||
| } | |||
| if (success) { | |||
| emitScalar(subscriber, value, r); | |||
| if (subscriber.queue == null || subscriber.queue.isEmpty()) { | |||
There was a problem hiding this comment.
assign subscriber.queue to local variable to avoid double volatile read?
|
reviewed 👍 |
|
Updated, thanks @davidmoten ! |
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes flatmap to make sure there is no element reordering happening on the fast-paths.
Related: #4206.