Implemented 'Synchronize' with 'lock' #409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RxJava-pull-requests #313 ABORTED |
|
Looks good, thank you! |
benjchristensen
added a commit
that referenced
this pull request
Sep 25, 2013
Implemented 'Synchronize' with 'lock'
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this pull request
Jan 9, 2014
Implemented 'Synchronize' with 'lock'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I implemented #84 to support that sending a lock to the
synchronizeoperator.I also found that there was a issue that
testMultiThreadedWithNPEandtestMultiThreadedWithNPEinMiddlemight fail in some special situation. WhenonErroris invoked before anyonNext, the last statementassertEquals(1, busyObserver.maxConcurrentThreads.get());in these methods will fail. I also fixed this issue in the pull request.