-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Add Schedulers.reset() for better testing #3986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,50 @@ | ||
package rx.schedulers; | ||
|
||
|
||
import org.junit.Test; | ||
import rx.Scheduler; | ||
import rx.internal.schedulers.*; | ||
import rx.plugins.RxJavaPlugins; | ||
import rx.plugins.RxJavaSchedulersHook; | ||
|
||
import static org.junit.Assert.assertTrue; | ||
|
||
public class ResetSchedulersTest { | ||
|
||
@Test | ||
public void reset() { | ||
RxJavaPlugins.getInstance().reset(); | ||
|
||
final TestScheduler testScheduler = new TestScheduler(); | ||
RxJavaPlugins.getInstance().registerSchedulersHook(new RxJavaSchedulersHook() { | ||
@Override | ||
public Scheduler getComputationScheduler() { | ||
return testScheduler; | ||
} | ||
|
||
@Override | ||
public Scheduler getIOScheduler() { | ||
return testScheduler; | ||
} | ||
|
||
@Override | ||
public Scheduler getNewThreadScheduler() { | ||
return testScheduler; | ||
} | ||
}); | ||
Schedulers.reset(); | ||
|
||
assertTrue(Schedulers.io().equals(testScheduler)); | ||
assertTrue(Schedulers.computation().equals(testScheduler)); | ||
assertTrue(Schedulers.newThread().equals(testScheduler)); | ||
|
||
RxJavaPlugins.getInstance().reset(); | ||
RxJavaPlugins.getInstance().registerSchedulersHook(RxJavaSchedulersHook.getDefaultInstance()); | ||
Schedulers.reset(); | ||
|
||
assertTrue(Schedulers.io() instanceof CachedThreadScheduler); | ||
assertTrue(Schedulers.computation() instanceof EventLoopsScheduler); | ||
assertTrue(Schedulers.newThread() instanceof rx.internal.schedulers.NewThreadScheduler); | ||
} | ||
|
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use atomics instead:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious what's the advantage of this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Synchronized holds the potential of getting blocked if somebody else is already in it. If the Schedulers is not constantly and concurrently reset all the time, the atomic approach is a single non-blocking volatile read of a non-null instance value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shutdown()
is currently a static method. Shouldcurrent.shutdown()
be justshutdown()
or shouldshutdown()
be changed to an instance method?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two problems:
shutdown()
is public API and that would be an incompatible changeSchedulers
as an instance somehow call an instance method on it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you propose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave the
shutdown()
as it is now.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright. Do you think there's any risk of deadlock since we'd be calling it from
getInstance()
and it callsgetInstance()
internally?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated in fe2157c