1.x: remove remaining field updaters #3979
Conversation
This is an internal API. Nobody is supposed to use it. Why not just remove it? |
|
External, custom operators may still depend on this utility method. |
| @@ -45,7 +45,9 @@ private BackpressureUtils() { | |||
| * @param n | |||
| * the number of requests to add to the requested count | |||
| * @return requested value just prior to successful addition | |||
| * @deprecated Android has issues with reflection-based atomics | |||
There was a problem hiding this comment.
s/Android/Samsung/ 😀
Let's not lump all of Android in with the likes of the insane OS developers at Samsung who modify Java system packages needlessly without rhyme or reason.
There was a problem hiding this comment.
It's one thing those devices can't find fields but how about reflection in general. Desktop Java does well with inlining and intrinsification of AtomicXFieldUpdaters; I'm not sure about Android in general through.
There was a problem hiding this comment.
Yeah I'm not sure. I would imagine the new runtime on Android 5.0+ could do something about it. I'll have to investigate it more.
Okey, let's remove it later. 👍 |
|
👍 |
This PR removes the remaining
AtomicXFieldUpdaters from the library because reflection is somewhat problematic on Android.This also deprecates the internal
BackpressureUtils.getAndAddRequestto indicaterequestedfield updater should not be used anymore.