1.x: map() and filter() should unsubscribe on crash eagerly #3890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| @Override | ||
| public void setProducer(Producer p) { | ||
| actual.setProducer(p); |
There was a problem hiding this comment.
Missing a call to super.setProducer?
There was a problem hiding this comment.
Map doesn't request on its own, unlike filter, so it can just pass along the producer to downstream.
There was a problem hiding this comment.
Ah, yeah. Makes sense.
This was referenced Apr 28, 2016
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current master, when the function in
maporfiltercrashes, the error is propagated but the upstream is not immediately unsubscribed but expected to happen eventually due to some other operator orSafeSubscriber.The fix, and also the restructuring of the unsubscription chain, makes sure the crash also unsubscribes immediately (unless a fatal one).
Related: StackOverflow question