Making RxPlugins reset() public #3820
Conversation
|
👍 |
|
Based on the discussion, it's definitely helpful, but also dangerous. Otherwise 👍 |
|
Yeah, same concern about dangerous that this method may add. It looks like an easy way to do testing but in multithreaded environment (integrational or functional tests for example) it may break a lot of things in "random" manner. @stevegury @akarnokd let's also mark it as |
|
Yeah, good idea for the |
shivangshah
force-pushed
the
rxplugins-reset-public
branch
from
dfa1b68 to
6cbbef4
Compare
|
Thanks for the feedback @stevegury , @artem-zinnatullin. Just added the |
|
Please add a javadoc block, and explicitly mention that resetting the plugins is dangerous/unsafe during application runtime (I suspect most people won't check the link), keep the link at the end. |
|
@shivangshah Friendly ping. Please update with Javadoc. |
|
@JakeWharton yes .. thanks for the reminder this totally slipped my mind .. Let me do it now .. |
Discussions found here: ReactiveX#2297 Adding @experimental tag because exposing reset() could be dangerous Adding javadocs for `reset()` API. Explicitly mentioning how caution is advised when using `reset()` API. Also mentioning links to detailed discussions on github issue.
shivangshah
force-pushed
the
rxplugins-reset-public
branch
from
6cbbef4 to
a2416ca
Compare
|
@JakeWharton : Done ! Let me know if we need to add anything else as a part of the documentation. |
|
👍 |
|
👍 |
This update on RxJava version is in regards to the PR that got merged [`here`](ReactiveX/RxJava#3820) for making RxJavaPlugins' `reset` method to be public. We have to work this around in Spring Sleuth. Details on the implementation can be found [`here`] (spring-cloud/spring-cloud-sleuth#243). 1.1.5
This update on RxJava version is in regards to the PR that got merged [`here`](ReactiveX/RxJava#3820) for making RxJavaPlugins' `reset` method to be public. We have to work this around in Spring Sleuth. Details on the implementation can be found [`here`] (spring-cloud/spring-cloud-sleuth#243). 1.1.5
* pull1007: Updating RxJava version to 1.1.5 This update on RxJava version is in regards to the PR that got merged [`here`](ReactiveX/RxJava#3820) for making RxJavaPlugins' `reset` method to be public. We have to work this around in Spring Sleuth. Details on the implementation can be found [`here`] (spring-cloud/spring-cloud-sleuth#243).
Discussions found here: #2297