1.x: Fix zip() - observer array becoming visible too early and causing NPE #3688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akarnokd
changed the title
| private static final class Zip<R> extends AtomicLong { | ||
| static final class Zip<R> extends AtomicLong { | ||
| /** */ | ||
| private static final long serialVersionUID = 5995274816189928317L; |
There was a problem hiding this comment.
We really need it? Also, javadoc comment above does not make sense
|
Few small things, otherwise lgtm 👍 |
akarnokd
force-pushed
the
ZipStartBarrierFix
branch
from
1fa8703 to
6a34137
Compare
akarnokd
force-pushed
the
ZipStartBarrierFix
branch
from
6a34137 to
6291fb9
Compare
|
Updated. |
|
👍 |
akarnokd
added a commit
that referenced
this pull request
Feb 10, 2016
1.x: Fix zip() - observer array becoming visible too early and causing NPE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported in #3687.
By the way, I see several other small problems with zip: it is implemented as an
Operatorand even though one can know the number of sources upfront, this indirection hides the fact. In addition, it uses SpMc queue but could just use Spsc because there is only one drain thread at a time.