1.x: fix doOnRequest premature requesting. #3662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good find thanks @akarnokd |
|
|
||
| producer.get().request(1); | ||
|
|
||
| System.out.println(requested); |
There was a problem hiding this comment.
May as well cull the sysout to reduce test noise
akarnokd
force-pushed
the
DoOnRequestFix
branch
from
9b09750 to
13ce7a9
Compare
|
Done. |
| @@ -76,5 +73,55 @@ public void onNext(Integer t) { | |||
| }); | |||
| assertEquals(Arrays.asList(3L,1L,2L,3L,4L,5L), requests); | |||
| } | |||
|
|
|||
| @Test | |||
| public void dontRequestIfDownstreamRequestsLate() { | |||
There was a problem hiding this comment.
Yay! You did it! @Test without test prefix, oh, I'm so happy now 😸
|
👍 |
1 similar comment
|
👍 |
zsxwing
added a commit
that referenced
this pull request
Feb 3, 2016
1.x: fix doOnRequest premature requesting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the operator is assembled and it sets the producer on the child, if the child doesn't request until the assembly is complete,
doOnRequestrequested the default Long.MAX_VALUE.