Skip to content

fix error handling in combineLatest #3641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

davidmoten
Copy link
Collaborator

combinator.call() was not wrapped in an appropriate try catch to prevent the error from being reported from an upstream operator.

This PR includes a unit test that failed on the original code.

@akarnokd
Copy link
Member

#3507 already takes care of this as well, but thanks.

@akarnokd akarnokd added the Bug label Jan 24, 2016
@davidmoten
Copy link
Collaborator Author

Ah good, thanks @akarnokd. I guess we can leave this open if it's possible that #3507 doesn't make the next release. By the way, the unit test in here would probably be nice to have in whichever PR makes it in first.

@akarnokd
Copy link
Member

I've updated #3507 with your test method.

@akarnokd
Copy link
Member

akarnokd commented Feb 3, 2016

#3661 merged

@akarnokd akarnokd closed this Feb 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants