1.x: Optimizate single just #3622
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -685,6 +679,9 @@ public void call(SingleSubscriber<? super T> te) { | |||
| * @see <a href="http://reactivex.io/documentation/operators/merge.html">ReactiveX operators documentation: Merge</a> | |||
| */ | |||
| public final static <T> Single<T> merge(final Single<? extends Single<? extends T>> source) { | |||
| if (source.getClass() == ScalarSynchronousSingle.class) { | |||
There was a problem hiding this comment.
It appears instanceof can be optimized much better by JIT than class equivalence checks. Could you rewrite this and all the other places?
| return new ScalarSynchronousSingle<T>(t); | ||
| } | ||
|
|
||
| final T t; |
There was a problem hiding this comment.
Let's rename this to value? Will improve readability of the code!
|
Nice PR! @Chaoba can you please remove merge commit from the PR (rebase should help)? |
|
@akarnokd and @artem-zinnatullin please review on #3642 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add similar optimization as ScalarSynchronousObservable to Single.just method.