1.x: Fix SyncOnSubscribeTest.testConcurrentRequests non-determinism #3536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test checks if onUnSubscribe is called but that happens after onCompleted is sent and as such, may run concurrently with the main thread where the mock is verified. The change switches to CountDownLatch to properly await the call to onUnsubscribe.
| @@ -532,7 +538,10 @@ public Integer call(Integer state, Observer<? super Integer> observer) { | |||
| inOrder.verify(o, times(finalCount)).onNext(any()); | |||
| inOrder.verify(o, times(1)).onCompleted(); | |||
| inOrder.verifyNoMoreInteractions(); | |||
| verify(onUnSubscribe, times(1)).call(any(Integer.class)); | |||
|
|
|||
| if (!l3.await(2, TimeUnit.SECONDS)) { | |||
There was a problem hiding this comment.
Static import for SECONDS will make code little nicer!
|
👍 |
1 similar comment
|
👍 |
akarnokd
added a commit
that referenced
this pull request
Nov 25, 2015
1.x: Fix SyncOnSubscribeTest.testConcurrentRequests non-determinism
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test checks if onUnSubscribe is called but that happens after
onCompleted is sent and as such, may run concurrently with the main
thread where the mock is verified. The change switches to CountDownLatch
to properly await the call to onUnsubscribe.