Clarify contracts of CompositeSubscription in its javadoc #3458
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current state of
CompositeSubscription
's javadoc — totally misleading 😄Every time we need to store some subscriptions in it then clear them and leave
CompositeSubscription
in an operable state we have to read its sources because its actual behavior is not consistent with the javadoc.CompositeSubscription.clear()
leavesCompositeSubscription
in operable state, when on the other handCompositeSubscription.unsubscribe()
setsisUnsubscribed = true
andCompositeSubscription
is not able to manage new subscriptions.