-
Notifications
You must be signed in to change notification settings - Fork 7.6k
2.x: Completable class for valueless event composition. #3439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
168 changes: 168 additions & 0 deletions
168
src/main/java/io/reactivex/internal/operators/completable/CompletableOnSubscribeConcat.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,168 @@ | ||
/** | ||
* Copyright 2015 Netflix, Inc. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in | ||
* compliance with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software distributed under the License is | ||
* distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See | ||
* the License for the specific language governing permissions and limitations under the License. | ||
*/ | ||
|
||
package io.reactivex.internal.operators.completable; | ||
|
||
import java.util.concurrent.atomic.*; | ||
|
||
import org.reactivestreams.*; | ||
|
||
import io.reactivex.*; | ||
import io.reactivex.Completable.*; | ||
import io.reactivex.disposables.Disposable; | ||
import io.reactivex.exceptions.MissingBackpressureException; | ||
import io.reactivex.internal.disposables.SerialResource; | ||
import io.reactivex.internal.queue.SpscArrayQueue; | ||
import io.reactivex.internal.subscriptions.SubscriptionHelper; | ||
import io.reactivex.plugins.RxJavaPlugins; | ||
|
||
public final class CompletableOnSubscribeConcat implements CompletableOnSubscribe { | ||
final Observable<? extends Completable> sources; | ||
final int prefetch; | ||
|
||
public CompletableOnSubscribeConcat(Observable<? extends Completable> sources, int prefetch) { | ||
this.sources = sources; | ||
this.prefetch = prefetch; | ||
} | ||
|
||
@Override | ||
public void accept(CompletableSubscriber s) { | ||
CompletableConcatSubscriber parent = new CompletableConcatSubscriber(s, prefetch); | ||
sources.subscribe(parent); | ||
} | ||
|
||
static final class CompletableConcatSubscriber | ||
extends AtomicInteger | ||
implements Subscriber<Completable>, Disposable { | ||
/** */ | ||
private static final long serialVersionUID = 7412667182931235013L; | ||
final CompletableSubscriber actual; | ||
final int prefetch; | ||
final SerialResource<Disposable> sr; | ||
|
||
final SpscArrayQueue<Completable> queue; | ||
|
||
Subscription s; | ||
|
||
volatile boolean done; | ||
|
||
volatile int once; | ||
static final AtomicIntegerFieldUpdater<CompletableConcatSubscriber> ONCE = | ||
AtomicIntegerFieldUpdater.newUpdater(CompletableConcatSubscriber.class, "once"); | ||
|
||
final ConcatInnerSubscriber inner; | ||
|
||
public CompletableConcatSubscriber(CompletableSubscriber actual, int prefetch) { | ||
this.actual = actual; | ||
this.prefetch = prefetch; | ||
this.queue = new SpscArrayQueue<>(prefetch); | ||
this.sr = new SerialResource<>(Disposable::dispose); | ||
this.inner = new ConcatInnerSubscriber(); | ||
} | ||
|
||
@Override | ||
public void onSubscribe(Subscription s) { | ||
if (SubscriptionHelper.validateSubscription(this.s, s)) { | ||
return; | ||
} | ||
this.s = s; | ||
actual.onSubscribe(this); | ||
s.request(prefetch); | ||
} | ||
|
||
@Override | ||
public void onNext(Completable t) { | ||
if (!queue.offer(t)) { | ||
onError(new MissingBackpressureException()); | ||
return; | ||
} | ||
if (getAndIncrement() == 0) { | ||
next(); | ||
} | ||
} | ||
|
||
@Override | ||
public void onError(Throwable t) { | ||
if (ONCE.compareAndSet(this, 0, 1)) { | ||
actual.onError(t); | ||
return; | ||
} | ||
RxJavaPlugins.onError(t); | ||
} | ||
|
||
@Override | ||
public void onComplete() { | ||
if (done) { | ||
return; | ||
} | ||
done = true; | ||
if (getAndIncrement() == 0) { | ||
next(); | ||
} | ||
} | ||
|
||
void innerError(Throwable e) { | ||
s.cancel(); | ||
onError(e); | ||
} | ||
|
||
void innerComplete() { | ||
if (decrementAndGet() != 0) { | ||
next(); | ||
} | ||
if (!done) { | ||
s.request(1); | ||
} | ||
} | ||
|
||
@Override | ||
public void dispose() { | ||
s.cancel(); | ||
sr.dispose(); | ||
} | ||
|
||
void next() { | ||
boolean d = done; | ||
Completable c = queue.poll(); | ||
if (c == null) { | ||
if (d) { | ||
if (ONCE.compareAndSet(this, 0, 1)) { | ||
actual.onComplete(); | ||
} | ||
return; | ||
} | ||
RxJavaPlugins.onError(new IllegalStateException("Queue is empty?!")); | ||
return; | ||
} | ||
|
||
c.subscribe(inner); | ||
} | ||
|
||
final class ConcatInnerSubscriber implements CompletableSubscriber { | ||
@Override | ||
public void onSubscribe(Disposable d) { | ||
sr.set(d); | ||
} | ||
|
||
@Override | ||
public void onError(Throwable e) { | ||
innerError(e); | ||
} | ||
|
||
@Override | ||
public void onComplete() { | ||
innerComplete(); | ||
} | ||
} | ||
} | ||
} |
93 changes: 93 additions & 0 deletions
93
...n/java/io/reactivex/internal/operators/completable/CompletableOnSubscribeConcatArray.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,93 @@ | ||
/** | ||
* Copyright 2015 Netflix, Inc. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in | ||
* compliance with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software distributed under the License is | ||
* distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See | ||
* the License for the specific language governing permissions and limitations under the License. | ||
*/ | ||
|
||
package io.reactivex.internal.operators.completable; | ||
|
||
import java.util.concurrent.atomic.AtomicInteger; | ||
|
||
import io.reactivex.Completable; | ||
import io.reactivex.Completable.*; | ||
import io.reactivex.disposables.*; | ||
|
||
public final class CompletableOnSubscribeConcatArray implements CompletableOnSubscribe { | ||
final Completable[] sources; | ||
|
||
public CompletableOnSubscribeConcatArray(Completable[] sources) { | ||
this.sources = sources; | ||
} | ||
|
||
@Override | ||
public void accept(CompletableSubscriber s) { | ||
ConcatInnerSubscriber inner = new ConcatInnerSubscriber(s, sources); | ||
s.onSubscribe(inner.sd); | ||
inner.next(); | ||
} | ||
|
||
static final class ConcatInnerSubscriber extends AtomicInteger implements CompletableSubscriber { | ||
/** */ | ||
private static final long serialVersionUID = -7965400327305809232L; | ||
|
||
final CompletableSubscriber actual; | ||
final Completable[] sources; | ||
|
||
int index; | ||
|
||
final SerialDisposable sd; | ||
|
||
public ConcatInnerSubscriber(CompletableSubscriber actual, Completable[] sources) { | ||
this.actual = actual; | ||
this.sources = sources; | ||
this.sd = new SerialDisposable(); | ||
} | ||
|
||
@Override | ||
public void onSubscribe(Disposable d) { | ||
sd.set(d); | ||
} | ||
|
||
@Override | ||
public void onError(Throwable e) { | ||
actual.onError(e); | ||
} | ||
|
||
@Override | ||
public void onComplete() { | ||
next(); | ||
} | ||
|
||
void next() { | ||
if (sd.isDisposed()) { | ||
return; | ||
} | ||
|
||
if (getAndIncrement() != 0) { | ||
return; | ||
} | ||
|
||
Completable[] a = sources; | ||
do { | ||
if (sd.isDisposed()) { | ||
return; | ||
} | ||
|
||
int idx = index++; | ||
if (idx == a.length) { | ||
actual.onComplete(); | ||
return; | ||
} | ||
|
||
a[idx].subscribe(this); | ||
} while (decrementAndGet() != 0); | ||
} | ||
} | ||
} |
133 changes: 133 additions & 0 deletions
133
...ava/io/reactivex/internal/operators/completable/CompletableOnSubscribeConcatIterable.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,133 @@ | ||
/** | ||
* Copyright 2015 Netflix, Inc. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in | ||
* compliance with the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software distributed under the License is | ||
* distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See | ||
* the License for the specific language governing permissions and limitations under the License. | ||
*/ | ||
|
||
package io.reactivex.internal.operators.completable; | ||
|
||
import java.util.Iterator; | ||
import java.util.concurrent.atomic.AtomicInteger; | ||
|
||
import io.reactivex.Completable; | ||
import io.reactivex.Completable.*; | ||
import io.reactivex.disposables.*; | ||
import io.reactivex.internal.disposables.EmptyDisposable; | ||
|
||
public final class CompletableOnSubscribeConcatIterable implements CompletableOnSubscribe { | ||
final Iterable<? extends Completable> sources; | ||
|
||
public CompletableOnSubscribeConcatIterable(Iterable<? extends Completable> sources) { | ||
this.sources = sources; | ||
} | ||
|
||
@Override | ||
public void accept(CompletableSubscriber s) { | ||
|
||
Iterator<? extends Completable> it; | ||
|
||
try { | ||
it = sources.iterator(); | ||
} catch (Throwable e) { | ||
s.onSubscribe(EmptyDisposable.INSTANCE); | ||
s.onError(e); | ||
return; | ||
} | ||
|
||
if (it == null) { | ||
s.onSubscribe(EmptyDisposable.INSTANCE); | ||
s.onError(new NullPointerException("The iterator returned is null")); | ||
return; | ||
} | ||
|
||
ConcatInnerSubscriber inner = new ConcatInnerSubscriber(s, it); | ||
s.onSubscribe(inner.sd); | ||
inner.next(); | ||
} | ||
|
||
static final class ConcatInnerSubscriber extends AtomicInteger implements CompletableSubscriber { | ||
/** */ | ||
private static final long serialVersionUID = -7965400327305809232L; | ||
|
||
final CompletableSubscriber actual; | ||
final Iterator<? extends Completable> sources; | ||
|
||
int index; | ||
|
||
final SerialDisposable sd; | ||
|
||
public ConcatInnerSubscriber(CompletableSubscriber actual, Iterator<? extends Completable> sources) { | ||
this.actual = actual; | ||
this.sources = sources; | ||
this.sd = new SerialDisposable(); | ||
} | ||
|
||
@Override | ||
public void onSubscribe(Disposable d) { | ||
sd.set(d); | ||
} | ||
|
||
@Override | ||
public void onError(Throwable e) { | ||
actual.onError(e); | ||
} | ||
|
||
@Override | ||
public void onComplete() { | ||
next(); | ||
} | ||
|
||
void next() { | ||
if (sd.isDisposed()) { | ||
return; | ||
} | ||
|
||
if (getAndIncrement() != 0) { | ||
return; | ||
} | ||
|
||
Iterator<? extends Completable> a = sources; | ||
do { | ||
if (sd.isDisposed()) { | ||
return; | ||
} | ||
|
||
boolean b; | ||
try { | ||
b = a.hasNext(); | ||
} catch (Throwable ex) { | ||
actual.onError(ex); | ||
return; | ||
} | ||
|
||
if (!b) { | ||
actual.onComplete(); | ||
return; | ||
} | ||
|
||
Completable c; | ||
|
||
try { | ||
c = a.next(); | ||
} catch (Throwable ex) { | ||
actual.onError(ex); | ||
return; | ||
} | ||
|
||
if (c == null) { | ||
actual.onError(new NullPointerException("The completable returned is null")); | ||
return; | ||
} | ||
|
||
c.subscribe(this); | ||
} while (decrementAndGet() != 0); | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akarnokd do you really see much sense in a separate class for arrays?
You can provide an override where passed array will be wrapped into
ArrayList
and then passed to theCompletableOnSubscribeConcatIterable
.Less code — less bugs :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Less allocation, more performant code.