2.x: fix GroupBy MissingBackpressureException due to main/group overflow #3426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akarnokd
force-pushed
the
GroupByOverrequestFix
branch
from
cd75166 to
8b242b7
Compare
|
I've changed the code a bit to handle another request pattern besides the fix for #3425 . |
akarnokd
force-pushed
the
GroupByOverrequestFix
branch
from
8b242b7 to
c4e31f9
Compare
|
I've also fixed the subscriber of the group becoming visible before the Subscription is set (similar bug as in #3381). |
|
Closing, will be included in the complete backport PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem with GroupBy is that a request(1) from the main source may
result in a new group, a value for another group or value for the
intended group. The latter two is handled by unicasting but the former
was not properly handled.