Skip to content

add backpressure support for defaultIfEmpty() #3042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/main/java/rx/Observable.java
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
import rx.exceptions.*;
import rx.functions.*;
import rx.internal.operators.*;
import rx.internal.producers.SingleProducer;
import rx.internal.util.*;
import rx.observables.*;
import rx.observers.SafeSubscriber;
Expand Down Expand Up @@ -3857,8 +3858,14 @@ public final Observable<T> debounce(long timeout, TimeUnit unit, Scheduler sched
* items, or the items emitted by the source Observable
* @see <a href="http://reactivex.io/documentation/operators/defaultifempty.html">ReactiveX operators documentation: DefaultIfEmpty</a>
*/
public final Observable<T> defaultIfEmpty(T defaultValue) {
return lift(new OperatorDefaultIfEmpty<T>(defaultValue));
public final Observable<T> defaultIfEmpty(final T defaultValue) {
//if empty switch to an observable that emits defaultValue and supports backpressure
return switchIfEmpty(Observable.create(new OnSubscribe<T>() {

@Override
public void call(Subscriber<? super T> subscriber) {
subscriber.setProducer(new SingleProducer<T>(subscriber, defaultValue));
}}));
}

/**
Expand Down
64 changes: 0 additions & 64 deletions src/main/java/rx/internal/operators/OperatorDefaultIfEmpty.java

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import rx.Observer;
import rx.Subscriber;
import rx.exceptions.TestException;
import rx.observers.TestSubscriber;

public class OperatorDefaultIfEmptyTest {

Expand Down Expand Up @@ -85,4 +86,28 @@ public void onCompleted() {
verify(o, never()).onNext(any(Integer.class));
verify(o, never()).onCompleted();
}

@Test
public void testBackpressureEmpty() {
TestSubscriber<Integer> ts = TestSubscriber.create(0);
Observable.<Integer>empty().defaultIfEmpty(1).subscribe(ts);
ts.assertNoValues();
ts.assertNoTerminalEvent();
ts.requestMore(1);
ts.assertValue(1);
ts.assertCompleted();
}

@Test
public void testBackpressureNonEmpty() {
TestSubscriber<Integer> ts = TestSubscriber.create(0);
Observable.just(1,2,3).defaultIfEmpty(1).subscribe(ts);
ts.assertNoValues();
ts.assertNoTerminalEvent();
ts.requestMore(2);
ts.assertValues(1, 2);
ts.requestMore(1);
ts.assertValues(1, 2, 3);
ts.assertCompleted();
}
}