Skip to content

Cannot customize ThreadFactory in GenericScheduledExecutorService #4171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ffgiraldez opened this issue Jul 7, 2016 · 4 comments
Closed
Milestone

Comments

@ffgiraldez
Copy link

ffgiraldez commented Jul 7, 2016

Some platform like AppEngine have limitations populating threads and have their own mechanism to do it. with last version (1.1.6 at this moment) it's not posible to use rx-java in gae due to don't exist a mechanism to override via RxPlugin or whatever the ThreadFactory in GenericScheduledExecutorService used in ObjectPool.

In 1.0.X version don't exist that class and ObjectPool(1.0.X) use Schedulers.computation().createWorker instead.
Please add some mechanism to pass our custom ThreadFactory into GenericScheduledExecutorService in order to use last version of rx-java in GAE

@ffgiraldez ffgiraldez changed the title Cannot customize GenericScheduledExecutorService ThreadFactory Cannot customize ThreadFactory in GenericScheduledExecutorService Jul 7, 2016
@akarnokd
Copy link
Member

akarnokd commented Jul 7, 2016

See #4173. It would be great if you could check that PR out and see if there isn't anything pre-initializing the GSES if your first action only touches RxJavaHooks.

@akarnokd
Copy link
Member

Closing via #4173.

@ffgiraldez
Copy link
Author

work like a charm with 1.1.7 using RxJavaHooks instead of RxJavaPlugin thanks a lot @akarnokd

@akarnokd
Copy link
Member

Great, thanks for confirming!

@akarnokd akarnokd added this to the 1.2 milestone Jul 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants