Skip to content

takeLast() javadoc suggestion #3027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davidmoten opened this issue Jun 18, 2015 · 2 comments
Closed

takeLast() javadoc suggestion #3027

davidmoten opened this issue Jun 18, 2015 · 2 comments

Comments

@davidmoten
Copy link
Collaborator

@DavidMGross takeLast and takeLastBuffer methods are inconsistent in the javadoc about their behaviour when less is available than requested. When less is available than requested all are emitted but this behaviour is not clear in the javadoc of all of the variations. Should I leave this to you?

@DavidMGross
Copy link
Collaborator

You should feel free to change the javadocs as you find errors,
ambiguities, missing information, or as you change the behavior of methods
(e.g. to add backpressure support). I've done a lot of work with these
javadocs as the tech writer guy, but philosophically I think the front-line
developers ought to consider it part of their responsibility to maintain
their accuracy.

On Wed, Jun 17, 2015 at 10:19 PM, Dave Moten [email protected]
wrote:

@DavidMGross https://github.com/DavidMGross takeLast and takeLastBuffer
methods are inconsistent in the javadoc about their behaviour when less is
available than requested. When less is available than requested all are
emitted but this behaviour is not clear in the javadoc of all of the
variations. Should I leave this to you?


Reply to this email directly or view it on GitHub
#3027.

David M. Gross
PLP Consulting

@davidmoten
Copy link
Collaborator Author

no probs

@akarnokd akarnokd closed this as completed Feb 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants