Finally Happens after onCompleted

[benjchristensen]

Looks like finallyDo is behaving wrong:

package rx.lang.groovy.examples
import rx.Observable

class Testing {

    static class myActionClass implements rx.util.functions.Action0 {
        void call() { println('Finally'); }
     }

    static main(args) {



        def myAction = new myActionClass();
        def numbers = Observable.toObservable([1, 2, 3, 4, 5]);

        numbers.finallyDo(myAction).subscribe(
          [ onNext: { println(it); },
            onCompleted:{ println("Sequence complete"); },
            onError:{ println("Error encountered"); } ]
        );

    }

}

Output:

1
2
3
4
5
Sequence complete
Finally

I believe "Finally" should happen before "Sequence Completed"

[prabirshrestha]

This issues was raised when finally PR was being sent. #196 (comment)

Here is the C# equivalent code I just checked with.

using System;
using System.Reactive.Linq;

var members = new[] { 1, 2, 3, 4, 5 }.ToObservable();

members
    .Finally(() => Console.WriteLine("Finally"))
    .Subscribe(Console.WriteLine /* next */, Console.WriteLine /* exception */, () => Console.WriteLine("Sequence Completed"));

Output:

1
2
3
4
5
Sequence Completed
Finally

Current behavior is correct.

[benjchristensen]

Great. Thank you for confirming with C# code.