dependency on com.google.code.findbugs

[MasseGuillaume]

Do you need a dependency on com.google.code.findbugs outside of testing?

http://mvnrepository.com/artifact/com.netflix.rxjava/rxjava-core/0.5.3

[benjchristensen]

It is used for these annotations (http://jsr-305.googlecode.com/svn/trunk/javadoc/javax/annotation/concurrent/package-summary.html):

import javax.annotation.concurrent.GuardedBy;
import javax.annotation.concurrent.ThreadSafe;

[benjchristensen]

Not sure if we can change it from 'compile' to 'provided' - we may be able to as these annotations should have nothing to do with normal runtime. Would need to try a deployment without that jar in the runtime classpath.

[benjchristensen]

@MasseGuillaume What exactly is the problem that this is causing?

Also, nothing about rxjava-scala should affect what version of Scala you are using as it specifically states the Scala dependency as 'provided' rather than a 'compile' dependency for the very reason of not forcing a particular version.

[MasseGuillaume]

It could lead to transitive dependencies.

I was analyzing scala-notebook dependencies and I saw that your Rx* Project depend on findbug. It's weird that a functional reactive library depends on a static analysis library so I tough it was just a mistake and you forgot to set a test dependency.

[benjchristensen]

Understood on the transitive dependency concern ... the bane of existence for our production app.

This particular dependency has seemed safe as it doesn't pull in anything else, but I'm open to removing it (not using the annotations), finding a replacement that's better or figuring out if it can be marked as 'provided' and not included for runtime since it's not critical for anything.

I have tried to keep transitive dependencies at an absolute minimum and have it at this currently for rxjava-core:

jsr305-2.0.0.jar
slf4j-api-1.7.0.jar

As stated above jsr305-2.0.0.jar could be eliminated if it's an issue.

The rxjava-scala module shouldn't add anything further to this beyond the obvious rxjava-core.jar and rxjava-scala.jar artifacts.

[benjchristensen]

The next release will remove this dependency as part of pull request #211