Added logic to avoid spinning in OnSubscribe while the PublishSubscriber

is terminating.

Author: akarnokd

src/main/java/rx/internal/operators/OperatorPublish.java

@@ -240,6 +240,8 @@ boolean checkTerminated(Object term, boolean empty) {
             if (term != null) {
                 if (nl.isCompleted(term)) {
                     if (empty) {
+                        // this will prevent OnSubscribe spinning on a terminated but not yet unsubscribed PublishSubscriber
+                        current.compareAndSet(this, null);
                         try {
                             for (InnerProducer<?> ip : producers.getAndSet(TERMINATED)) {
                                 ip.child.onCompleted();
@@ -251,6 +253,8 @@ boolean checkTerminated(Object term, boolean empty) {
                     }
                 } else {
                     Throwable t = nl.getError(term);
+                    // this will prevent OnSubscribe spinning on a terminated but not yet unsubscribed PublishSubscriber
+                    current.compareAndSet(this, null);
                     try {
                         for (InnerProducer<?> ip : producers.getAndSet(TERMINATED)) {
                             ip.child.onError(t);
@@ -265,7 +269,6 @@ boolean checkTerminated(Object term, boolean empty) {
         }
 
         void dispatch() {
-            // TODO
             synchronized (this) {
                 if (emitting) {
                     missed = true;