Add AndroidSchedulers.reset() for better testing support #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZacSweers
changed the title
| @@ -0,0 +1,42 @@ | |||
| package rx.android.schedulers; | |||
|
Blocked by ReactiveX/RxJava#3986 |
|
ReactiveX/RxJava#3986 is in now. Let me know if you'd rather the doc here match that one |
|
It should be whatever is in RxJava |
|
Updated the doc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponds to ReactiveX/RxJava#3986
This adds a
reset()method toAndroidSchedulers, with the main benefit being improved testing support. This does slightly tweak the internal API ofAndroidSchedulersto use agetInstance()approach to allow lazy init. This way we don't have to replace the singleton instance duringreset()and allow it to lazily re-evaluate upon next usage. Otherwise, if you change your scheduler hook, you'd always have to make sure you set it before you callSchedulers.reset().