Skip to content

Commit 0f44a0e

Browse files
authored
[ROCm][Build] Clean up the ROCm build (vllm-project#19040) (#567)
Signed-off-by: Gregory Shtrasberg <[email protected]>
1 parent 328cf17 commit 0f44a0e

File tree

4 files changed

+1
-15
lines changed

4 files changed

+1
-15
lines changed

CMakeLists.txt

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -186,11 +186,6 @@ if(VLLM_GPU_LANG STREQUAL "HIP")
186186
set(CMAKE_${VLLM_GPU_LANG}_FLAGS_DEBUG "${CMAKE_${VLLM_GPU_LANG}_FLAGS_DEBUG} -O0 -ggdb3")
187187
set(CMAKE_CXX_FLAGS_DEBUG "${CMAKE_CXX_FLAGS_DEBUG} -O0 -ggdb3")
188188

189-
#
190-
# Set rocm version dev int.
191-
#
192-
list(APPEND VLLM_GPU_FLAGS "-DROCM_VERSION=${ROCM_VERSION_DEV_INT}")
193-
194189
#
195190
# Certain HIP functions are marked as [[nodiscard]], yet vllm ignores the result which generates
196191
# a lot of warnings that always mask real issues. Suppressing until this is properly addressed.

docker/Dockerfile.rocm

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
# default base image
22
ARG REMOTE_VLLM="0"
3-
ARG BUILD_RPD="1"
43
ARG COMMON_WORKDIR=/app
54
ARG BASE_IMAGE=rocm/vllm-dev:base
65

@@ -87,13 +86,6 @@ RUN case "$(which python3)" in \
8786
*) ;; esac
8887

8988
RUN python3 -m pip install --upgrade huggingface-hub[cli]
90-
ARG BUILD_RPD
91-
RUN if [ ${BUILD_RPD} -eq "1" ]; then \
92-
git clone -b nvtx_enabled https://github.com/ROCm/rocmProfileData.git \
93-
&& cd rocmProfileData/rpd_tracer \
94-
&& pip install -r requirements.txt && cd ../ \
95-
&& make && make install \
96-
&& cd hipMarker && python3 setup.py install ; fi
9789

9890
# Install vLLM
9991
RUN --mount=type=bind,from=export_vllm,src=/,target=/install \

docs/getting_started/installation/gpu/rocm.inc.md

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,8 +179,6 @@ It is important that the user kicks off the docker build using buildkit. Either
179179
It provides flexibility to customize the build of docker image using the following arguments:
180180

181181
- `BASE_IMAGE`: specifies the base image used when running `docker build`. The default value `rocm/vllm-dev:base` is an image published and maintained by AMD. It is being built using <gh-file:docker/Dockerfile.rocm_base>
182-
- `USE_CYTHON`: An option to run cython compilation on a subset of python files upon docker build
183-
- `BUILD_RPD`: Include RocmProfileData profiling tool in the image
184182
- `ARG_PYTORCH_ROCM_ARCH`: Allows to override the gfx architecture values from the base docker image
185183

186184
Their values can be passed in when running `docker build` with `--build-arg` options.

requirements/rocm.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,6 @@ peft
1414
pytest-asyncio
1515
tensorizer>=2.9.0
1616
setuptools-scm>=8
17+
setuptools>=77.0.3,<80.0.0
1718
runai-model-streamer==0.11.0
1819
runai-model-streamer-s3==0.11.0

0 commit comments

Comments
 (0)