Move to ESM #69
Merged
Move to ESM #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs more changes to support tree shaking. I will handle this later. |
|
What's needed to merge this? Happy to help @LitoMore . |
|
@PierBover Thank you for pinging me. I wil pick up it this week. |
|
@LitoMore now that https://github.com/Qix-/color-convert/pull/102 landed, are you still planning to move this one forward too? |
|
@michaelfaith Sure. |
|
@Qix- Marked this PR as ready. |
|
Glad we're finally at a time in Javascript's history where swizzling is no longer seen as necessary 🙃 Though I have to admit I enjoyed writing it. EDIT: Turns out I already came to this conclusion at some point before:
|
|
Thanks! Released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #56
Closes #68
Changes
simple-swizzlefeature