Skip to content

Commit b9212af

Browse files
author
Jordan Adler
committed
Skip the test not if it is OSX, but if it is Py3.6+, which appears to be the origination of the behavior breakage
1 parent 579a197 commit b9212af

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/future/utils/__init__.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@
5757

5858
PY3 = sys.version_info[0] == 3
5959
PY35_PLUS = sys.version_info[0:2] >= (3, 5)
60+
PY36_PLUS = sys.version_info[0:2] >= (3, 6)
6061
PY2 = sys.version_info[0] == 2
6162
PY26 = sys.version_info[0:2] == (2, 6)
6263
PY27 = sys.version_info[0:2] == (2, 7)

tests/test_future/test_urllibnet.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -109,9 +109,8 @@ def test_getcode(self):
109109

110110
# On Windows, socket handles are not file descriptors; this
111111
# test can't pass on Windows.
112-
#
113-
# On macOS, this behavior is undocumented and this test fails.
114-
@unittest.skipIf(sys.platform in ('darwin', 'win32',), 'not appropriate for macOS or Windows')
112+
@unittest.skipIf(sys.platform in ('darwin', 'win32',), 'not appropriate for Windows')
113+
@unittest.skipIf(utils.PY36_PLUS, 'test not applicable on Python 3.5 and higher')
115114
@skip26
116115
def test_fileno(self):
117116
# Make sure fd returned by fileno is valid.

0 commit comments

Comments
 (0)