Skip to content

Update node version for integration tests #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 6, 2024

Conversation

cffls
Copy link
Collaborator

@cffls cffls commented May 5, 2024

This commit made a few changes:

  1. Upgrade cardano-node version to v8.x.x from v1.x.x. This will help with testing when entering Chang hardfork.
  2. Upgrade ogmios to 6.x.x because of change 1.
  3. Replace built-in ogmios chain context with https://gitlab.com/viperscience/ogmios-python because of change 2.
  4. Temporarily disable Kupo in integration test because ogmios-python doesn't support kupo yet.

This commit made a few changes:
1. Upgrade cardano-node version to v8.x.x from v1.x.x. This will help with testing when entering Chang hardfork.
2. Upgrade ogmios to 6.x.x because of change 1.
3. Replace built-in ogmios chain context with https://gitlab.com/viperscience/ogmios-python because of change 2.
4. Temporarily disable Kupo in integration test because ogmios-python doesn't support kupo yet.
Copy link

codecov bot commented May 5, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 83.61%. Comparing base (486d97f) to head (386191a).

Files Patch % Lines
pycardano/backend/cardano_cli.py 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #345      +/-   ##
==========================================
- Coverage   83.62%   83.61%   -0.02%     
==========================================
  Files          29       29              
  Lines        3719     3722       +3     
  Branches      936      939       +3     
==========================================
+ Hits         3110     3112       +2     
  Misses        445      445              
- Partials      164      165       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nielstron nielstron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cffls cffls merged commit 20e8ed7 into Python-Cardano:main May 6, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants