Skip to content

Accept cbor and str as input type in submit_tx #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions pycardano/backend/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from dataclasses import dataclass
from typing import Dict, List, Union

from pycardano.exception import InvalidArgumentException
from pycardano.address import Address
from pycardano.network import Network
from pycardano.plutus import ExecutionUnits
Expand Down Expand Up @@ -158,17 +159,24 @@ def _utxos(self, address: str) -> List[UTxO]:
"""
raise NotImplementedError()

def submit_tx(self, tx: Transaction):
def submit_tx(self, tx: Union[Transaction, bytes, str]):
"""Submit a transaction to the blockchain.

Args:
tx (Transaction): The transaction to be submitted.
tx (Union[Transaction, bytes, str]): The transaction to be submitted.

Raises:
:class:`InvalidArgumentException`: When the transaction is invalid.
:class:`TransactionFailedException`: When fails to submit the transaction to blockchain.
"""
return self.submit_tx_cbor(tx.to_cbor("bytes"))
if isinstance(tx, Transaction):
return self.submit_tx_cbor(tx.to_cbor("bytes"))
elif isinstance(tx, bytes):
return self.submit_tx_cbor(tx)
else:
raise InvalidArgumentException(
f"Invalid transaction type: {type(tx)}, expected Transaction, bytes, or str"
)

def submit_tx_cbor(self, cbor: Union[bytes, str]):
"""Submit a transaction to the blockchain.
Expand Down