-
-
Notifications
You must be signed in to change notification settings - Fork 76
Correctly parse List[X] annotated objects #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #170 +/- ##
==========================================
- Coverage 85.78% 85.45% -0.34%
==========================================
Files 26 26
Lines 2814 2832 +18
Branches 672 679 +7
==========================================
+ Hits 2414 2420 +6
- Misses 296 302 +6
- Partials 104 110 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
c489984
to
3894d49
Compare
Thanks! The change makes sense. Could you add a test for it? LGTM otherwise. |
Future todos (for another PR)
|
@cffls Please review |
d883ae8
to
e375088
Compare
Again, coverage submission failed :/ |
Imperatorlang allows users to specify PlutusData like this
This was previously not correctly parsed by Pycardano. I suggest the List notation is also added to the main Pycardano, as it otherwise lacks the ability to build complex objects.