-
-
Notifications
You must be signed in to change notification settings - Fork 76
Refactor ogmios.py module maintainability #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UPDATE. including black format check in ci/cd static analyses part
Codecov Report
@@ Coverage Diff @@
## main #114 +/- ##
==========================================
- Coverage 86.36% 86.36% -0.01%
==========================================
Files 24 24
Lines 2633 2647 +14
Branches 515 514 -1
==========================================
+ Hits 2274 2286 +12
- Misses 265 267 +2
Partials 94 94
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
REFACTOR. re-order methods so that helper functions are right beneath the main function for readability
…dependently testable REFACTOR. renaming chain tip status checking helper method
Major Updates
Minor Updates
|
cffls
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
In my opinion,
pycardano.backend.base.GenesisParameters
andpycardano.backend.base.ProtocolParameters
should be frozen dataclasses with no optional attributes.I tested refactoring these dataclasses to require all field values, but it touches many of ogmios.py module.
Goal
GenesisParameters
andProtocolParameters
become frozen dataclasses with full data requirements