Skip to content

Improve bip32.py type hint #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 25, 2022
Merged

Improve bip32.py type hint #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7c31a5e
ADD. adding mypy to dev-dependency
daehan-koreapool Oct 25, 2022
cd10bcc
ADD. targetting Python 3.7 type hint
daehan-koreapool Oct 25, 2022
1ca8d61
FIX. correcting Tuple type annotion syntax
daehan-koreapool Oct 25, 2022
4c57990
REFACTOR. improving derive() method branching self-explanatory
daehan-koreapool Oct 25, 2022
7b5ccb5
REFACTOR. most of HDWallet attributes can be explicitly typed since t…
daehan-koreapool Oct 25, 2022
ec4f9c7
UPDATE. returning False for is_mnemonic() explicitly
daehan-koreapool Oct 25, 2022
72685f6
UPDATE. avoid type-converting an already defined variable
daehan-koreapool Oct 25, 2022
5427cfb
UPDATE. including mypy check in Github action
daehan-koreapool Oct 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ jobs:
- name: Install dependencies
run: |
poetry install
- name: Lint with flake8
- name: Run static analyses
run: |
poetry run flake8 pycardano
make qa
- name: Run unit tests
run: |
poetry run pytest --doctest-modules --ignore=examples --cov=pycardano --cov-config=.coveragerc --cov-report=xml
Expand Down
3 changes: 2 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,9 @@ test: ## runs tests
test-single: ## runs tests with "single" markers
poetry run pytest -s -vv -m single

qa: ## runs static analysis with flake8
qa: ## runs static analyses
poetry run flake8 pycardano
poetry run mypy --install-types --non-interactive pycardano

format: ## runs code style and formatter
poetry run isort .
Expand Down
109 changes: 77 additions & 32 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading