This repository was archived by the owner on Nov 3, 2023. It is now read-only.
Make checkers extensible via entry point pydocstyles_style
#359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the following for the checkers - * Improves re compile. Currently we were doing a re compile inside function calls. Moves this out so that this compile only happens once. * Improve checker code quality - * Current checker is stateless. It was still written as a class which added additional complexity with addition of passing of `self` `cls` and using staticmethod decorators. * Move the checker hook out of the class. * Slice up the checks into base, other and numpy style checks.
sambhav
changed the title
pydocstyles_stylepydocstyles_style
2 tasks
This commit adds an entry point called pydocstyle_styles which allows checks to be loaded dynamically.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependent on PR #358.
This is an experimental PR based on the discussion from the google thread.
The only additional commit here apart from the #358 commits is c4aa001
which is approximately ~30 LoC