Skip to content

fix: lost references to the files.add method changed to files.addAll #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 29, 2020

Conversation

zebateira
Copy link
Contributor

The only affected tutorial is "Regular Files API". Affected lessons are lessons number 3, 5 and 6.

@zebateira zebateira requested a review from terichadbourne July 22, 2020 14:52
@zebateira
Copy link
Contributor Author

From the convo with @achingbrain

the plan for the future is to make it throw if you pass input that would result in multiple files being created

So I propose leaving the issue as it is: a user will be able to use ipfs.add(files). In the future we will get a release that will make that specific case fail, and then we'll be able to show an appropriate error message to the user.

@terichadbourne
Copy link
Member

Merging as is for now, noting that we'll have to come back and update validation when the js-ipfs team settles on some more under-the-hood edits to how these methods work. See #498.

@terichadbourne terichadbourne merged commit 6b8f2b2 into code Jul 29, 2020
@zebateira zebateira deleted the fix/js-ipfs-0-48-0-updates branch July 29, 2020 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants