-
Notifications
You must be signed in to change notification settings - Fork 67
Feature: add events page #365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- use "Yes" and "No" strings for the approved column - add name parsing: now using given and family name
It doesn't seem to be a problem: https://developers.google.com/sheets/api/limits
|
There are other limits tho: https://support.google.com/drive/answer/37603?hl=en
Since we have 24 columns, then our maximum number of events will be around 208. |
@zebateira I've removed the option to shorten the past events list as we discussed and made the text you click to view them all focusable and noticeable on hover. I believe these are the only fields from the spreadsheet that we'll actually need to save to {
"id": 2,
"city": "Toronto",
"country": "Canada",
"startTime": "2020-05-15T12:30:00",
"endTime": "2020-05-15T14:00:00",
"duration": 90,
"tutorials": ["0003", "0005"],
"cocUrl": "https://some.event/coc",
"url": "https://some.event",
"type": "meetup",
"hostedByName": "IPFS Boston",
"hostedByUrl": "https://meetup.com",
"hostedAtName": "AwesomeConf",
"hostedAtUrl": "https://conference.com"
}, |
@terichadbourne yes sounds good 👌 |
88afe35
to
fb53c59
Compare
@terichadbourne added a whitelist of properties to only keep the properties you listed 👌 |
@zebateira I've deleted all the old test data from our spreadsheet so we only have real past and future events there now. We're no longer using columns L (end time) or M (how is this workshop being presented) in the form, so those will always be blank. Can you confirm I won't mess up your data fetching functionality if I delete them from the spreadsheet? Also, your data fetching code is creating start time, end time, and duration fields, but we now only have start times. Mind updating your code accordingly? |
Deleting or reordering columns will break the code yeah. I'll update the code and delete the columns as well :) |
@terichadbourne done! |
@terichadbourne cron job setup 🕐 |
closes #362
partially addresses #90
TODO:
<Card />
componentevents.json
approved
column