Skip to content

Move Countly to proto.school domain #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 15, 2019
Merged

Conversation

terichadbourne
Copy link
Member

Closes #269

Blocked as we wait for Countly to update the TLS certificate, but putting in this draft PR to make it easier for others to wrap this up while I'm out.

Note that to test you will need to comment out line 70 and uncomment line 65 in public/index.html in order to register clicks from localhost. We'll then need to ensure visits from Chrome, Firefox, and Safari are all registered, including with the standard "disable cross-site tracking" option checked in Safari.

@terichadbourne terichadbourne added the docs-ipfs In scope for IPFS Docs Working Group label Jul 25, 2019
@terichadbourne
Copy link
Member Author

Countly has set up the security certificate for us so this now appears to be working.
I've:

  • incorporated Diogo's recent update that sends our testing data to a separate Countly test app so as not to mess up the stats (mirroring what was done in merged PR feat: add Countly app keys #285)
  • changed the cly.src so that it uses the latest version of countly so it will have all features, as we've done in the unmerged PR feat: track user events in Countly #282 to make linkClick views work
  • changed our Countly URL to countly.proto.school (the network requests appear to go there and seem to be unaware of the cly.src value which is on cloudflare.

For me it seems to be successfully tracking from:

  • Safari without cross-site tracking disabled
  • Safari with cross-site tracking disabled (default, didn't track previously)
  • Chrome with standard settings
  • Crome with 3rd party cookies disabled
  • Firefox with standard security level
  • Firefox with custom security disabling 3rd party cookies

It does not appear to work with:

  • Firefox on "strict" security level

Screenshots of where I'm adjusting these settings below. There may be other spots for blocking cross-site tracking that I haven't located. (I could find settings called third-party tracking for Chrome and Firefox so guessed that 3rd party cookies might be related 🤷‍♀️).

Firefox with standard security (works)
image

Firefox with strict security (doesn't work)
image

Firefox with custom security disabling 3rd party cookies (works)
image

Safari with and without cross-site tracking prevented (both work)
image

Chrome with and without "block third party cookies" (both work)
image

@olizilla would you have time to test this from your computer while @fsdiogo is out tomorrow (Thursday)? (Note that you no longer have to comment and uncomment certain sections in the code, and that your results will appear in the "TEST ProtoSchool" app, not the "ProtoSchool" app in Countly.)

@terichadbourne terichadbourne requested review from mikeal and olizilla and removed request for mikeal August 14, 2019 22:22
@terichadbourne terichadbourne marked this pull request as ready for review August 14, 2019 22:22
@terichadbourne terichadbourne merged commit df292bd into code Aug 15, 2019
@terichadbourne terichadbourne deleted the fix-countly-domain branch August 15, 2019 17:47
@terichadbourne
Copy link
Member Author

this is merged, with the main change being the countly url pointing to countly.proto.school, but none of my browsers are picking up the change. @fsdiogo @olizilla @mikeal are any of you getting the network XHR requests going to countly.proto.school? I don't know if the merge failed or if my browsers are caching old code despite my efforts to clear them.

@fsdiogo
Copy link
Collaborator

fsdiogo commented Aug 16, 2019

The requests are going to countly.proto.school:

ss

@terichadbourne
Copy link
Member Author

terichadbourne commented Aug 16, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-ipfs In scope for IPFS Docs Working Group
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate Countly to proto.school domain
2 participants