Skip to content

feat: add ability to view solutions in lessons #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 23, 2019

Conversation

fsdiogo
Copy link
Collaborator

@fsdiogo fsdiogo commented Apr 22, 2019

sol

Closes #89.

@fsdiogo fsdiogo self-assigned this Apr 22, 2019
@fsdiogo
Copy link
Collaborator Author

fsdiogo commented Apr 23, 2019

Workflow

solution

@fsdiogo fsdiogo marked this pull request as ready for review April 23, 2019 10:11
@fsdiogo fsdiogo requested a review from terichadbourne April 23, 2019 10:11
@terichadbourne
Copy link
Member

@fsdiogo Looking good! I pushed a couple of commits to tweak some typos or confusing language I happened to come across while testing and to add instructions for including _solution in your Vue file.

Are you comfortable with "View Solution" being clickable even when you're already viewing the solution, or would you rather make the option disappear or change to non-clickable "Viewing solution" text until the user types something new and the code editor contents no longer match the solution code? This former is what happens with the "Reset code" option, which disappears when the code editor contents match the default code.

@fsdiogo
Copy link
Collaborator Author

fsdiogo commented Apr 23, 2019

We were using _solution because it was like a private variable and it wasn't used. I switched to solution to be streamlined like the code one.

@fsdiogo
Copy link
Collaborator Author

fsdiogo commented Apr 23, 2019

Are you comfortable with "View Solution" being clickable even when you're already viewing the solution, or would you rather make the option disappear or change to non-clickable "Viewing solution" text until the user types something new and the code editor contents no longer match the solution code? This former is what happens with the "Reset code" option, which disappears when the code editor contents match the default code.

I'd prefer to always have the option to click the View Solution. It doesn't bother me that the Reset code is hidden when we have the default code on the screen.

@terichadbourne
Copy link
Member

@fsdiogo Okay, I'm good to have you merge this if you're feeling ready! I'll change _solution to solution in my MFS tutorials

@fsdiogo fsdiogo merged commit 4ed2b3d into code Apr 23, 2019
@fsdiogo fsdiogo deleted the feat/add-view-solution-to-lessons branch April 23, 2019 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: view solution
2 participants