Skip to content

Pin xarray version < 2022.11.0 to fix nc_time_axis import bug in that… #346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

ktyle
Copy link
Contributor

@ktyle ktyle commented Nov 24, 2022

Resolves #343 for now. We can likely remove the pin with the next release of xarray.

We'll also need to do a similar pin for any cookbooks that rely on an nc_time_axis import.

@ktyle ktyle requested review from brian-rose and r-ford November 24, 2022 15:58
@ktyle ktyle requested a review from a team as a code owner November 24, 2022 15:58
@github-actions
Copy link

github-actions bot commented Nov 24, 2022

This pull request is being automatically built with GitHub Actions and Netlify. To see the status of your deployment, click below.

🔍 Git commit SHA: c716bfc
✅ Deployment Preview URL: https://637f96dc319a392b7a2f2f8b--pythia-foundations.netlify.app

Copy link
Member

@r-ford r-ford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring this out!

Copy link
Member

@brian-rose brian-rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks @ktyle for sleuthing this out promptly!

@brian-rose brian-rose merged commit faa9aca into ProjectPythia:main Nov 25, 2022
@ktyle ktyle deleted the fix_xarray branch January 17, 2023 00:57
brian-rose pushed a commit to brian-rose/pythia-foundations that referenced this pull request Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code errors on Xarray pages
3 participants