-
Notifications
You must be signed in to change notification settings - Fork 46
Drop in Unidata xarray workshop notebook #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🚀 📚 Preview for git commit SHA: cac9b82 at: https://607dfc3beb6b1100c1da012e--pythia-foundations.netlify.app |
core/xarray/xarray-nc-cf.ipynb
Outdated
@@ -0,0 +1,864 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(just my initial test of ReviewNB) How about including making "Common Data Model (CDM)" a clickable link, pointing to https://www.unidata.ucar.edu/software/netcdf-java/v4.3/CDM/ ?
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That link appears to be dead, but I linked to https://docs.unidata.ucar.edu/netcdf-java/current/userguide/common_data_model_overview.html
I've pinged @ProjectPythia/education for review (I'll try to publicly self-review the content too.) As discussed in #42 and today's meeting notes, we've decided that this PR should be our main hub for focused review of a core content notebook. By our next meeting 5/13, we can plan to have this be our best current take at what we want our demonstrative notebook material to look like in terms of pacing, scope, presentation, and organization. We can then take this notebook and turn it into the template we generally plan to apply to the rest of our core teaching notebooks, as well as to provide for outside contributors to this book. |
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Just fixed a conflict in |
🚀 📚 Preview for git commit SHA: 8619fc7 at: https://608b0ed67a13565419677ecb--pythia-foundations.netlify.app |
Most of my in-line comments are small nits. One more substantive comment is that reading and writing CF compliant NetCDF files is an important and complex topic. I'm wondering if a more concise and simple example should be used here to simply demonstrate read/writing data from NetCDF (without CF compliance), and having a separate book (chapter?) that gives more in depth coverage of this topic. Several examples could be included starting from the most simple, but useful CF compliant file (e.g. 2D, no projection, static) and working up to the more complex (e.g. 3D, map projection, time-varying). I think this area is one that is not well-covered elsewhere and is vitally important for folks working with CF data. What do others think? |
With the expectation that today's meeting will focus on this excellent notebook, here is a "core dump" of my thoughts ...
|
I agree with much of @ktyle's comments here. For pedagogical purposes, I support moving the CF conventions to a different notebook, and splitting the xarray content up with some more headings and shorter sections. Two key features of xarray (to my mind) that don't appear in this notebook but could are:
To me point 2 is the real "killer feature" that shows the huge advantage of using xarray over plain numpy arrays when working with gridded data. I think it would be great to slip this in somewhere early on in our tutorials. |
Retweet what @ktyle and @brian-rose mentioned - I think maybe mentioning cf-xarray within the cf notebook would be good too. Maybe a quick example of an arithmetic example, detailing how it deals with dimensionality of the datasets. |
* Convert xarray (#33) to template * Update toc with template * Add template info to how to contribute * Draft full template guiding text * Use html_image myst extension. Also fix markdown table rendering in template notebook * Enable all MyST extensions * Respond to reviews: tags etc * Fix inline link to template * Cleanup and reorder prereqs * Fix typos * Clarify prereqs table instructions * Responses to review + mathjax * Trim and clarify system requirements point Co-authored-by: Brian Rose <[email protected]>
There are still lots of comments on this PR (Xarray is still XArray throughout the document, for one). I will do a thorough review after these conversations are resolved. |
🚀 📚 Preview for git commit SHA: 1dab418 at: https://60c7aed29b4f16222ac57797--pythia-foundations.netlify.app |
🚀 📚 Preview for git commit SHA: 3bb5c7b at: https://60c9911861508b72af2f6511--pythia-foundations.netlify.app |
🚀 📚 Preview for git commit SHA: 7b193e8 at: https://60c996f20d3b4d620e9d871a--pythia-foundations.netlify.app |
Wiill review asap this a.m. |
Assuming this gets merged in form close to what's currently here, we should open a new issue about sorting out the CF material, which is currently in a hidden notebook on this branch at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a big improvement! Just a few small changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much improved, Brian! I just had a few nits, then should be good to go.
🚀 📚 Preview for git commit SHA: 5541912 at: https://60ca28a04a3bb80166f5d430--pythia-foundations.netlify.app |
In meetings until 11:30am MT, but will jump right on it then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Approved and merging.
* Cleanup initial release draft Clarify organization, trim file names, verify template-based consistency. Clear out extra metadata and run all notebooks on standard kernel. * Incorporate #33 into cleanup * Incorporate feedback
This is a drop-in of this notebook from our workshop materials with interactive sections replaced with equivalent demonstrations.
Some notes: