Skip to content

Commit b791cf7

Browse files
add payloadid to task dispatch
Signed-off-by: Jack Schofield <[email protected]>
1 parent cc17a5e commit b791cf7

File tree

3 files changed

+10
-6
lines changed

3 files changed

+10
-6
lines changed

src/WorkflowExecuter/Common/EventMapper.cs

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,12 @@ namespace Monai.Deploy.WorkflowManager.WorkfowExecuter.Common
1010
{
1111
public static class EventMapper
1212
{
13-
public static TaskDispatchEvent ToTaskDispatchEvent(TaskExecution task, string workflowId, string correlationId, StorageServiceConfiguration configuration)
13+
public static TaskDispatchEvent ToTaskDispatchEvent(TaskExecution task, string workflowInstanceId, string correlationId, string payloadId, StorageServiceConfiguration configuration)
1414
{
1515
Guard.Against.Null(task, nameof(task));
16-
Guard.Against.Null(workflowId, nameof(workflowId));
17-
Guard.Against.Null(correlationId, nameof(correlationId));
16+
Guard.Against.NullOrWhiteSpace(workflowInstanceId, nameof(workflowInstanceId));
17+
Guard.Against.NullOrWhiteSpace(correlationId, nameof(correlationId));
18+
Guard.Against.NullOrWhiteSpace(payloadId, nameof(payloadId));
1819
Guard.Against.Null(configuration, nameof(configuration));
1920

2021
var inputs = new List<Messaging.Common.Storage>();
@@ -36,7 +37,7 @@ public static TaskDispatchEvent ToTaskDispatchEvent(TaskExecution task, string w
3637

3738
return new TaskDispatchEvent
3839
{
39-
WorkflowInstanceId = workflowId,
40+
WorkflowInstanceId = workflowInstanceId,
4041
TaskId = task.TaskId,
4142
ExecutionId = task.ExecutionId.ToString(),
4243
CorrelationId = correlationId,
@@ -45,6 +46,7 @@ public static TaskDispatchEvent ToTaskDispatchEvent(TaskExecution task, string w
4546
Inputs = inputs,
4647
TaskPluginType = task.TaskType,
4748
Metadata = task.Metadata,
49+
PayloadId = payloadId,
4850
IntermediateStorage = new Messaging.Common.Storage
4951
{
5052
Bucket = configuration.Settings["bucket"],

src/WorkflowExecuter/Services/WorkflowExecuterService.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -439,7 +439,7 @@ private async Task<List<TaskExecution>> CreateTaskDestinations(WorkflowInstance
439439

440440
private async Task<bool> DispatchTask(WorkflowInstance workflowInstance, TaskExecution taskExec, string correlationId)
441441
{
442-
var taskDispatchEvent = EventMapper.ToTaskDispatchEvent(taskExec, workflowInstance.Id, correlationId, _storageConfiguration);
442+
var taskDispatchEvent = EventMapper.ToTaskDispatchEvent(taskExec, workflowInstance.Id, correlationId, workflowInstance.PayloadId, _storageConfiguration);
443443
var jsonMesssage = new JsonMessage<TaskDispatchEvent>(taskDispatchEvent, MessageBrokerConfiguration.WorkflowManagerApplicationId, taskDispatchEvent.CorrelationId, Guid.NewGuid().ToString());
444444

445445
await _messageBrokerPublisherService.Publish(TaskDispatchRoutingKey, jsonMesssage.ToMessage());

tests/UnitTests/WorkflowExecuter.Tests/Common/EventMapperTests.cs

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,12 +47,14 @@ public void ToTaskDispatchEvent_ValidAeTitleWorkflowRequest_ReturnsTaskDispatch(
4747

4848
var workflowId = Guid.NewGuid().ToString();
4949
var correlationId = Guid.NewGuid().ToString();
50+
var payloadId = Guid.NewGuid().ToString();
5051

5152
var expectedTask = new TaskDispatchEvent
5253
{
5354
WorkflowInstanceId = workflowId,
5455
TaskId = task.TaskId,
5556
ExecutionId = task.ExecutionId.ToString(),
57+
PayloadId = payloadId,
5658
CorrelationId = correlationId,
5759
Status = TaskExecutionStatus.Created,
5860
TaskPluginType = task.TaskType,
@@ -82,7 +84,7 @@ public void ToTaskDispatchEvent_ValidAeTitleWorkflowRequest_ReturnsTaskDispatch(
8284
}
8385
};
8486

85-
var taskDispatch = EventMapper.ToTaskDispatchEvent(task, workflowId, correlationId, configuration);
87+
var taskDispatch = EventMapper.ToTaskDispatchEvent(task, workflowId, correlationId, payloadId, configuration);
8688

8789
taskDispatch.Should().BeEquivalentTo(expectedTask, options =>
8890
options.Excluding(t => t.CorrelationId));

0 commit comments

Comments
 (0)