-
Notifications
You must be signed in to change notification settings - Fork 512
Initial Notebook UI Mode in VS Code Insiders #2789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Notebook UI Mode in VS Code Insiders #2789
Conversation
package-lock.json
Outdated
"resolved": "https://botbuilder.myget.org/F/botframework-cli/npm/@types/node/-/@types/node-14.0.1.tgz", | ||
"integrity": "sha1-XZPgoJnNCs1e89W948CG4fSf9ow=", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this because we need a fast-release version for VSCode compat? Ideally we don't have to move off of npm (and to a repository with a deprecated signing hash algorithm) for long
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears that the vscode-dts is to blame here. When this API is stable, we wont need this so just ignore this for now.
kernel?: vscode.NotebookKernel; | ||
|
||
constructor() { | ||
this.kernel = this; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this property needed? It seems like we've declared it, so we should be able to pass this
wherever we currently use this.kernel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes the vscode API uses it under the hood. I could potentially have 2 classes, one that implements vscode.NotebookContentProvider
and one that implements vscode.NotebookKernel
... but I felt one was fine, since vscode.NotebookKernel
isn't that big of an interface.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah gotcha. This makes sense -- one of the great advantages of interfaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, this originally was one interface, but they broke it up into 2 recently.
9697ed1
to
219dc57
Compare
kernel?: vscode.NotebookKernel; | ||
|
||
constructor() { | ||
this.kernel = this; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah gotcha. This makes sense -- one of the great advantages of interfaces
@rjmholt I've just added a couple tests :) I'll probably add more. |
Co-authored-by: TylerLeonhardt <[email protected]>
Co-authored-by: TylerLeonhardt <[email protected]>
5a350a2
to
a0a1c2c
Compare
rip codacy who knows where you went |
@rjmholt this should be ready now. |
Co-authored-by: TylerLeonhardt <[email protected]>
…e-powershell into notebook-ui-support
PR Summary
This adds Notebook mode capabilities only in:
powershell.notebooks.showToggleButton
Added settings:
powershell.notebooks.showToggleButton
- shows the button at the top right that will open your file in Notebook modepowershell.notebooks.saveMarkdownCellsAs
- new markdown cells need to either use block comments or line comments in the file. This setting determines which type of comment to useImportant notes:
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
x
between the square brackets.Please mark anything not applicable to this PR
NA
.WIP:
to the beginning of the title and remove the prefix when the PR is ready