Support Preview mechanism #1707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerLeonhardt
force-pushed
the
support-preview-build
branch
from
9d295c4 to
ab3df78
Compare
|
Can we query the loaded extensions and if we see an already loaded mscode-powershell of some sort, pop a warning dialog telling the user to disable one of the two extensions? |
rjmholt
reviewed
Jan 22, 2019
vscode-powershell.build.ps1
Outdated
| task UpdateReadme { | ||
| $newReadmeTop = '# PowerShell Language Support for Visual Studio Code | ||
|
|
||
| > ## ATTENTION: This is the PREVIEW version of the PowerShell extension for VSCode which contains features that are being evaluated for stable |
There was a problem hiding this comment.
I would maybe also make a note about supporting PS 5.1+
There was a problem hiding this comment.
added. Although in the future both stable and preview will only support 5.1+
|
@rkeithhill I thought it couldn't be done... but I figured it out :)
I don't think I can programmatically disable one or the other... but at least this is in their face. |
rjmholt
approved these changes
Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This removes the dependency on the name of the extension being "ms-vscode.PowerShell". It's a bit of a workaround until this is resolved.
Also, this allows you to build preview versions the extension that have the name "PowerShell Preview". To build a preview version of the extension, that is to say,
a version of the extension named "PowerShell Preview",
You can simply change the version in the package.json to include
-previewat the end.When you build, this will:
PR Checklist
Note: Tick the boxes below that apply to this pull request by putting an
xbetween the square brackets.Please mark anything not applicable to this PR
NA.WIP:to the beginning of the title and remove the prefix when the PR is ready