Initialize repository #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests versions 3 and 5
SteveL-MSFT
requested changes
Feb 2, 2018
README.md
Outdated
| ## Supports PowerShell Core and Windows PowerShell | ||
|
|
||
| PowerShell Core is a cross-platform (Windows, Linux, and macOS) automation and configuration tool/framework that works well with your existing tools and is optimized for dealing with structured data (e.g. JSON, CSV, XML, etc.), REST APIs, and object models. It includes a command-line shell, an associated scripting language and a framework for processing cmdlets. |
There was a problem hiding this comment.
Please use semantic linebreaks. Basically after end of sentence and also break up large sentences onto two lines. Makes it easier to comment and show diffs. GitHub will render it correctly.
README.md
Outdated
| Windows PowerShell is a Windows command-line shell designed especially for system administrators. Windows PowerShell includes an interactive prompt and a scripting environment that can be used independently or in combination | ||
|
|
||
| The PowerShellStandard has been created to assist developers create modules and PowerShell hosts which will use only APIs that exist across different versions of PowerShell |
There was a problem hiding this comment.
We should consistently refer to this as "PowerShell Standard" (with whitespace)
README.md
Outdated
| ## PowerShell Standard Libraries | ||
|
|
||
| Two PowerShellStandard `.nupgk` versions are available: |
README.md
Outdated
| - This allows you to create PowerShell modules and host which will run on PowerShell Version 3 and later including PowerShellCore | ||
|
|
||
| - PowerShellStandard.Library Version 5 |
SteveL-MSFT
requested changes
Feb 2, 2018
build.psm1
Outdated
| } | ||
| } | ||
|
|
||
| function Export-NPKG |
There was a problem hiding this comment.
Seems like we should either spell it as Export-Nupkg or Export-NugetPackage
build.psm1
Outdated
| @@ -0,0 +1,54 @@ | |||
| function Start-Build { | |||
There was a problem hiding this comment.
Discussion with community we agreed to standardize on just build.ps1 with some common switches rather than a module. See PowerShell/vscode-powershell#1127 (comment)
SteveL-MSFT
approved these changes
Feb 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the source for PowerShellStandard 3
Add source file for PowerShellStandard 5
Add tests and build scripts
Add
.nuspecfiles