Skip to content

Fix completions not being added to list #756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 28, 2018
Merged

Fix completions not being added to list #756

merged 1 commit into from
Sep 28, 2018

Conversation

rjmholt
Copy link
Contributor

@rjmholt rjmholt commented Sep 28, 2018

Found a bad regression where we weren't returning any completions.

This fixes that.

TylerLeonhardt
TylerLeonhardt approved these changes Sep 28, 2018
View reviewed changes
Copy link
Member

@TylerLeonhardt TylerLeonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@rjmholt rjmholt merged commit 4cff0c7 into PowerShell:master Sep 28, 2018
@rjmholt rjmholt deleted the fix-completions-regression branch December 12, 2018 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkeithhill rkeithhill Awaiting requested review from rkeithhill

@SeeminglyScience SeeminglyScience Awaiting requested review from SeeminglyScience

1 more reviewer

@TylerLeonhardt TylerLeonhardt TylerLeonhardt approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjmholt @TylerLeonhardt