Skip to content

Make PSSA includerule list updatable #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 9, 2016
Merged

Conversation

kapilmb
Copy link

@kapilmb kapilmb commented Dec 6, 2016

No description provided.

@daviwil
Copy link
Contributor

daviwil commented Dec 8, 2016

Hey man, can you rebase on the latest develop changes and add some documentation comments to these two things:

Analysis\AnalysisService.cs(56,25): error CS1591: Missing XML comment for publicly visible type or member 'AnalysisService.ActiveRules' 
Analysis\AnalysisService.cs(160,36): error CS1591: Missing XML comment for publicly visible type or member 'AnalysisService.GetPSScriptAnalyzerRules()' 

If you build the project in Release mode it will give you errors where there need to be comments. I fixed the ones that were missing from the Code Actions PR.

Once that's done I'll get this merged!

@kapilmb kapilmb force-pushed the kapilmb/UpdatablePSSARules branch from 7d0547f to 0f42699 Compare December 9, 2016 09:52
@kapilmb kapilmb force-pushed the kapilmb/UpdatablePSSARules branch from 08d045a to f298def Compare December 9, 2016 10:42
@kapilmb kapilmb changed the title [WIP] Make PSSA includerule list updatable Make PSSA includerule list updatable Dec 9, 2016
@kapilmb
Copy link
Author

kapilmb commented Dec 9, 2016

@daviwil added the requested inline documentation and rebased on develop.

@daviwil
Copy link
Contributor

daviwil commented Dec 9, 2016

Looks good, merging it!

@daviwil daviwil merged commit 1f3df7a into develop Dec 9, 2016
@daviwil daviwil deleted the kapilmb/UpdatablePSSARules branch December 9, 2016 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants