-
Notifications
You must be signed in to change notification settings - Fork 236
Fixes #94 - adds support for conditional breakpoints #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #94 - adds support for conditional breakpoints #172
Conversation
This adds some unit tests for conditional breakpoints and refactors some existing unit tests I wrote to be a bit more DRY. Also, VSCode supports column breakpoints in its protocol. And PowerShell supports breakpoints on columns other than 1. So why don't I see any UI in VSCode to create a breakpoint at a specific column? Is there something we have to do to declare support for column breakpoints?
Assert.Equal(10, breakpoints[1].LineNumber); | ||
Assert.False(breakpoints[1].Verified); | ||
Assert.NotNull(breakpoints[1].Message); | ||
Assert.Contains("Unexpected token '-ez'", breakpoints[1].Message); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome!
This is great work man, I'm really excited for this feature to come online! If you're ready you can merge it. |
Regarding column breakpoints, I haven't seen anything in the UI for that yet. Was sort of expecting that I could put the cursor somewhere, right click and Add Breakpoint but it's not there. We might have to ask about that. |
It is weird that the protocol supports column breakpoints but the UI doesn't. Oh well. At least we will have conditional breakpoints. BTW I ran into a "gotcha" - ScriptBlock parsing will catch a number of parse errors but it won't catch this function = { Write-Warning "What do you think this is - C#?" }
$i == 1 Outputs:
This is a bummer because somebody will invariably forget to use |
Yeah, if there's a way to catch that and throw an error (especially suggesting the usage of |
…e breakpoint conditon message like $i == 3 or $i > 5.
…akpoints Fixes #94 - adds support for conditional breakpoints
That looks great! |
Prepare 0.6.0 release
This adds some unit tests for conditional breakpoints and refactors some existing unit tests I wrote to be a bit more DRY. Also, VSCode supports column breakpoints in its protocol. And PowerShell supports breakpoints on columns other than 1. So why don't I see any UI in VSCode to create a breakpoint at a specific column? Is there something we have to do to declare support for column breakpoints?