Skip to content

Use RootUri.LocalPath for workspace path #1094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2019
Merged

Use RootUri.LocalPath for workspace path #1094

merged 1 commit into from
Nov 13, 2019

Conversation

TylerLeonhardt
Copy link
Member

@TylerLeonhardt TylerLeonhardt commented Nov 6, 2019 •
edited
Loading

Fixes #1093
Fixes PowerShell/vscode-powershell#2288

RootPath is shorthand for RootUri.AbsolutePath which comes in the wrong format on Windows. This should use the correct \ and the likes.

Also RootPath is deprecated.

cc @SeeminglyScience

@TylerLeonhardt TylerLeonhardt mentioned this pull request Nov 10, 2019
Closed
@TylerLeonhardt TylerLeonhardt merged commit 651cdfa into PowerShell:master Nov 13, 2019
@TylerLeonhardt TylerLeonhardt deleted the fix-use-localpath branch November 13, 2019 19:06
@TylerLeonhardt TylerLeonhardt mentioned this pull request Nov 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rjmholt rjmholt rjmholt approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EditorServices can't find PSScriptAnalyzerSettings.psd1 in relative path $psEditor.Workspace.Path returns LSP style path
2 participants
@TylerLeonhardt @rjmholt